Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add icechunk recipe #28803

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

add icechunk recipe #28803

wants to merge 22 commits into from

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Jan 10, 2025 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/icechunk/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/icechunk/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12702036546. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 10, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/icechunk/meta.yaml) and found some lint.

Here's what I've got...

For recipes/icechunk/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12702243174. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/icechunk/meta.yaml) and found it was in an excellent condition.

@andersy005
Copy link
Member Author

andersy005 commented Jan 10, 2025 •
edited
Loading

@conda-forge/staged-recipes and/or @conda-forge/help-python / @conda-forge/help-rust, this is ready for review/merge

@github-actions GitHub Actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

ocefpaf
ocefpaf reviewed Jan 10, 2025
View reviewed changes
recipes/icechunk/meta.yaml Show resolved Hide resolved
recipes/icechunk/meta.yaml Outdated Show resolved Hide resolved
ocefpaf
ocefpaf reviewed Jan 10, 2025
View reviewed changes
recipes/icechunk/meta.yaml Outdated Show resolved Hide resolved
@andersy005
Copy link
Member Author

thank you for the feedback, @ocefpaf

xhochy
xhochy reviewed Jan 11, 2025
View reviewed changes
recipes/icechunk/meta.yaml Outdated Show resolved Hide resolved
ocefpaf
ocefpaf reviewed Jan 13, 2025
View reviewed changes
recipes/icechunk/meta.yaml Outdated Show resolved Hide resolved
ocefpaf
ocefpaf reviewed Jan 13, 2025
View reviewed changes
recipes/icechunk/meta.yaml Outdated Show resolved Hide resolved
ocefpaf
ocefpaf reviewed Jan 13, 2025
View reviewed changes
recipes/icechunk/meta.yaml Outdated
@@ -0,0 +1,54 @@
{% set name = "icechunk" %}
{% set version = "0.1.0a10" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one falls under https://github.com/conda-forge/cfep/blob/main/cfep-05.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless i'm missing something, this guide doesn't seem to have any examples of how to apply this to packages in staged-recipes before they have a feedstock repo.

any tips on how to do this?

andersy005
andersy005 commented Jan 13, 2025
View reviewed changes
recipes/icechunk/meta.yaml
Comment on lines +2 to +9
{% set version = "0.1.0-alpha.10" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://github.com/earth-mover/icechunk/archive/refs/tags/icechunk-v{{ version }}.tar.gz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf, the following results in an error

                      ^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/render.py", line 981, in render_recipe
    m.config.compute_build_id(m.name(), m.version(), reset=reset_build_id)
                                        ^^^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/metadata.py", line 1533, in version
    check_bad_chrs(version, "package/version")
  File "/opt/conda/lib/python3.12/site-packages/conda_build/metadata.py", line 776, in check_bad_chrs
    raise CondaBuildUserError(
conda_build.exceptions.CondaBuildUserError: Bad character(s) (-) in package/version: 0.1.0-alpha.10.

do you have any recommendations on how to avoid this issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that version in a valid PEP440 form? Also, you will need to follow CFEP-05 here or release/ask a stable version upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

@xhochy xhochy xhochy left review comments

Assignees
No one assigned
Labels
python review-requested staged-recipes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andersy005 @conda-forge-admin @xhochy @ocefpaf